Ticket25573 #262
Closed
Ticket25573 #262
Conversation
We allow their ENDs, SENDMEs, and DATA cells to not count as dropped until the windows are empty, or we get an END.
Also count valid path bias check cells as valid data.
Actually cover the new code..
…w one Unlike the rest of this branch, this commit does change client behavior and also avoids data corrupton by avoiding mixing up old stream ids with new ones. Does that make it a feature or a bug? Who can say. This is technically a feature change from like the first version of Tor also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Check END, SENDME, and DATA cells against half-closed stream ids in order to properly report dropped bytes to the control port.
This change does not affect behavior -- it only affects what is reported to the CIRC_BW event.
The text was updated successfully, but these errors were encountered: