Bug #27049: Consider hs circs before deciding no circuits are open. #263
Conversation
…open. Fix changes file bug number typos.
Pull Request Test Coverage Report for Build 3183
|
dgoulet-tor
reviewed
Aug 28, 2018
src/or/circuitlist.c
Outdated
| @@ -625,7 +625,7 @@ circuit_any_opened_circuits(void) | |||
| TO_CIRCUIT(next_circ)->state == CIRCUIT_STATE_OPEN && | |||
| TO_CIRCUIT(next_circ)->purpose != CIRCUIT_PURPOSE_C_MEASURE_TIMEOUT && | |||
| next_circ->build_state && | |||
| next_circ->build_state->desired_path_len == DEFAULT_ROUTE_LEN) { | |||
| next_circ->build_state->desired_path_len >= DEFAULT_ROUTE_LEN) { | |||
How does that work with single onion service circuits? I'm not entirely sure, because of preemptive circuit building, if a tor client can NOT have at least 3-hop circuits but I'm guessing their could be a window that it can happen?
Hrmm yeah. Ok. We should count SoS circuits here, too. Tried to do that in this commit: 8c950e7
changes/bug27409
Outdated
| @@ -0,0 +1,6 @@ | |||
| o Minor bugfixes (onion services): | |||
| - When circuits timeout, count other other onion service circuits when | |||
Double "other" ?
…open. Handle single hop onion services.
…open. Fix changes typo.
teor2345
reviewed
Dec 4, 2018
| if (!circ->build_state) | ||
| return 0; | ||
|
|
||
| if ((circ->rend_data || circ->hs_ident) && |
Does this test cover single-hop into and rend circuits?
(HSDir circuits are always 3 hops or more for single onion services.)
Every HS circuits have the identifier attached to them. I think this is enough to cover the intro/rend circuits because of the path length of 1.
The HSDir circuit with 3 hops will be caught by the next condition below it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: