Rustfmt notravis #275
Closed
Rustfmt notravis #275
Conversation
added 4 commits
Aug 11, 2018
Fix typo from fe66d06. The exclamation point is what lets an attribute apply to an entire crate, without the ! it's practically a placebo. Fix on commits af182d4 and b605929, and note there are still missing docs in both crypto and protover, for now. https://doc.rust-lang.org/reference/attributes.html
These are the 12 stable and documented configuration options, set to their default values. use_small_heuristics is only stabilized in rustfmt 0.9, so maintain support for 0.8.x for now by commenting it out. comment_width is unstable and did nothing, since wrap_comments defaults to false. Default values gotten from `rustfmt --print-config default rustfmt.toml`. https://github.com/rust-lang-nursery/rustfmt/blob/e7932fa9c2591c45a37a24305de90cb63128afcf/Configurations.md
teor2345
reviewed
Aug 16, 2018
doc/HACKING/CodingStandardsRust.md
Outdated
| @@ -104,7 +104,7 @@ repo. | |||
| Documentation | |||
| --------------- | |||
|
|
|||
| You MUST include `#[deny(missing_docs)]` in your crate. | |||
| You MUST include `#[!deny(missing_docs)]` in your crate. | |||
Typo: #![deny(missing_docs)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
From 'rustfmt-notravis' at https://gitgud.io/onionk/tor.git
The text was updated successfully, but these errors were encountered: