Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug27226 029 #282

Merged
merged 2 commits into from Aug 21, 2018
Merged

Bug27226 029 #282

merged 2 commits into from Aug 21, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Aug 20, 2018

No description provided.

nmathewson added 2 commits Aug 20, 2018
@nmathewson
Use our x509 wrapper code in tor_tls_cert_matches_key()
c1f476a 
This allows us to mock our own tor_tls_get_peer_certificate()
function in order to test ..cert_matches_key(), which will in turn
allow us to simplify test_tortls_cert_matches_key() considerably.

Prep work for the fix for 27226.
@nmathewson
Rewrite test_tortls_cert_matches_key()
85a8792 
Unlike the old test, this test no will no longer mess around with
the forbidden internals of any openssl data structures.

Additionally, it verifies several other behaviors of
tor_tls_cert_matches_key() that we had wanted to verify, such as
the possibility of the certificate's key not matching.

Fixes bug 27226; bugfix on 0.2.5.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Aug 20, 2018

Coverage Status

Coverage increased (+0.0009%) to 50.334% when pulling 85a8792 on nmathewson:bug27226_029 into 4c355ff on torproject:maint-0.2.9.

@torproject-pusher torproject-pusher merged commit 85a8792 into torproject:maint-0.2.9 Aug 21, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment