Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket25573 v2 squashed2 #296

Conversation

Labels
None yet
Projects
None yet
2 participants
@mikeperry-tor
Copy link
Contributor

@mikeperry-tor mikeperry-tor commented Aug 29, 2018

Reorganized + squashed branch for https://trac.torproject.org/projects/tor/ticket/25573

It does not modify the actual list.
We allow their CONNECTEDs, RESOLVEDs, ENDs, SENDMEs, and DATA cells to not
count as dropped until the windows are empty, or we get an END.

This commit does not change behavior. It only changes CIRC_BW event field
values.
Avoid data corrupton by avoiding mixing up old stream ids with new ones.

This commit changes client behavior.
TRUNCATED cells were ignored while in path bias. Now they are obeyed, and
cause us to tear down the circuit. The actual impact is minimal, since we
would just wait around for a probe that would never arrive before.

This commit changes client behavior.
@mikeperry-tor mikeperry-tor mentioned this pull request Aug 29, 2018
@coveralls
Copy link

@coveralls coveralls commented Aug 29, 2018

Coverage Status

Coverage increased (+0.3%) to 59.81% when pulling e5c5f90 on mikeperry-tor:ticket25573-v2-squashed2 into 0483f7f on torproject:maint-0.3.4.

Have fun squashing this future Mike! Hah!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment