Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23082: Fix tor_addr_parse() to reject invalid addresses #302

Closed
wants to merge 7 commits into from
Closed

#23082: Fix tor_addr_parse() to reject invalid addresses #302

wants to merge 7 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rl1987 @coveralls @nmathewson
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Aug 31, 2018

https://trac.torproject.org/projects/tor/ticket/23082
rl1987 and others added 4 commits Aug 31, 2018
@rl1987
Improve bracket handling in tor_addr_parse()
23ed863 
* Actually check for second bracket
* Only attempt parsing IPv4 address when no brackets found
@rl1987
Add tests for tor_addr_parse, separate from tor_addr_port_parse.
feae813
@rl1987
Reject addresses with needless trailing colon
01eb164
@rl1987
Add changes file
1baa270
@coveralls
Copy link

@coveralls coveralls commented Aug 31, 2018 •
edited

Coverage Status

Coverage increased (+0.003%) to 59.564% when pulling e85939f on rl1987:bug23082 into 1c62adb on torproject:master.

rl1987 added 3 commits Sep 1, 2018
@rl1987
Move a check for trailing colon to tor_inet_pton()
5438ff3 
That way, string_is_valid_ipv6_address() can benefit from it
@rl1987
Code cleanups for tor_addr_parse()
ad165f7
@rl1987
fixup! Move a check for trailing colon to tor_inet_pton()
e85939f
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Oct 30, 2018

Squashed and merged!

@nmathewson nmathewson closed this Oct 30, 2018
pylls added a commit to pylls/tor that referenced this issue Jul 8, 2019
@pylls
circpad_machines_init() currently loads the prop torproject#302 machi…
6c2814c 
…nes so a better reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment