Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networkstatus mmap #316

Merged
merged 7 commits into from Oct 31, 2018
Merged

Networkstatus mmap #316

merged 7 commits into from Oct 31, 2018

Conversation

Reviewers

@ahf ahf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @ahf @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 11, 2018

No description provided.

nmathewson added 6 commits Sep 11, 2018
@nmathewson
Consdiff: use lengths on inputs so they don't need NUL at the end
5595b21 
This is part of #27244, so that we can safely mmap consensus
documents.
@nmathewson
Stop memcpy'ing uncompressed consensuses when making diffs
e014b72
@nmathewson
Revise networkstatus parsing code to use lengths
abaca3f 
This way the networkstatus can be parsed without being
NUL-terminated, so we can implement 27244 and mmap our consensus objects.
@nmathewson
Replace "read consensus from disk" with "map consensus from disk".
7e3005a 
Implements 27244, and should save a bunch of RAM on clients.
@nmathewson
Followup: Make authority_cert_parse_from_string() take length too
04bb701
@nmathewson
Changes file for feature27244
81a5448
@coveralls
Copy link

@coveralls coveralls commented Sep 11, 2018

Coverage Status

Coverage increased (+0.0009%) to 59.833% when pulling 81a5448 on nmathewson:networkstatus_mmap into e5601f1 on torproject:master.

ahf
ahf approved these changes Oct 19, 2018
View changes
src/feature/dircache/consdiffmgr.c
consensus_cache_entry_t *ent)
uncompress_or_set_ptr(const char **out, size_t *outlen,
char **owned_out,
consensus_cache_entry_t *ent)
{
const uint8_t *body;
size_t bodylen;

Copy link
Member

@ahf ahf Oct 19, 2018

tor_assert(owned_out != NULL) maybe?

@nmathewson
Fix remaining cases of using consensus without a len parameter.
5941405 
(Thanks to cyberpunks for noting two of them!)
@torproject-pusher torproject-pusher merged commit 5941405 into torproject:master Oct 31, 2018
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment