Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check waitpid return value and exit status in tinytest.c #319

Merged
merged 1 commit into from Sep 13, 2018
Merged

Check waitpid return value and exit status in tinytest.c #319

merged 1 commit into from Sep 13, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 12, 2018

It's possible for a unit test to report success via its pipe, but to
fail as it tries to clean up and exit. Notably, this happens on a
leak sanitizer failure.

Fixes bug 27658; bugfix on 0.2.2.4-alpha when tinytest was
introduced.
@nmathewson
Check waitpid return value and exit status in tinytest.c
73a37d1 
It's possible for a unit test to report success via its pipe, but to
fail as it tries to clean up and exit.  Notably, this happens on a
leak sanitizer failure.

Fixes bug 27658; bugfix on 0.2.2.4-alpha when tinytest was
introduced.
@coveralls
Copy link

@coveralls coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.006%) to 49.965% when pulling 73a37d1 on nmathewson:bug27658_029 into 198b635 on torproject:maint-0.2.9.

@torproject-pusher torproject-pusher merged commit 73a37d1 into torproject:maint-0.2.9 Sep 13, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment