Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an --enable-pic option for people who hack Tor into libraries #321

Merged
merged 1 commit into from Sep 13, 2018
Merged

Add an --enable-pic option for people who hack Tor into libraries #321

merged 1 commit into from Sep 13, 2018

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @dgoulet-tor @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 12, 2018

Closes ticket 23846
@nmathewson
Add an --enable-pic option for people who hack Tor into libraries
0aec613 
Closes ticket 23846
@coveralls
Copy link

@coveralls coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at 61.867% when pulling 0aec613 on nmathewson:ticket23846 into 19dbc38 on torproject:master.

dgoulet-tor
dgoulet-tor reviewed Sep 13, 2018
View changes
configure.ac
TOR_CHECK_CFLAGS(-fPIE)
if test "$enable_pic" != "yes"; then
TOR_CHECK_CFLAGS(-fPIE)
fi
TOR_CHECK_LDFLAGS(-pie, "$all_ldflags_for_check", "$all_libs_for_check")
Copy link
Contributor

@dgoulet-tor dgoulet-tor Sep 13, 2018

Shouldn't that LDFLAGS check be in the if/fi ?

Also, no LDFLAGS for -fPIC ?

Copy link
Contributor Author

@nmathewson nmathewson Sep 13, 2018

No -- I'll document why. It's a little subtle.

@torproject-pusher torproject-pusher merged commit 0aec613 into torproject:master Sep 13, 2018
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment