Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In conditionvar_timeout test, wait for threads to timeout #331

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Labels
None yet
Projects
None yet
4 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 14, 2018

Previously we just waited 200msec, which was not enough on slow/busy
systems.

Fixes bug 27073; bugfix on 0.2.6.3-alpha when the test was introduced.

Previously we just waited 200msec, which was not enough on slow/busy
systems.

Fixes bug 27073; bugfix on 0.2.6.3-alpha when the test was introduced.
@coveralls
Copy link

@coveralls coveralls commented Sep 14, 2018

Pull Request Test Coverage Report for Build 4127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1106 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.08%) to 50.04%

Files with Coverage Reduction New Missed Lines %
src/or/circuituse.c 1 1.11%
src/ext/trunnel/trunnel.c 1 34.48%
src/or/directory.h 3 50.0%
src/or/routerlist.h 3 0.0%
src/or/circuitstats.c 7 73.71%
src/or/protover.c 16 93.58%
src/common/tortls.c 22 96.76%
src/or/dns.c 147 16.06%
src/or/router.c 199 33.57%
src/or/control.c 707 16.97%
Totals Coverage Status
Change from base Build 2144: 0.08%
Covered Lines: 29435
Relevant Lines: 58823

💛 - Coveralls

@nmathewson
Copy link
Contributor Author

@nmathewson nmathewson commented Sep 30, 2018

merged to master; marked for backport.

@nmathewson nmathewson closed this Sep 30, 2018
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 8, 2019

Re-opening to get CI on a recent merge.

@teor2345 teor2345 reopened this Mar 8, 2019
@torproject-pusher torproject-pusher merged commit 7a0ff5b into torproject:maint-0.2.9 Mar 13, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment