Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CID 1433643 #34

Merged
merged 1 commit into from Mar 30, 2018
Merged

Fix CID 1433643 #34

merged 1 commit into from Mar 30, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tlyu @tor-bot
@tlyu
Copy link
Contributor

@tlyu tlyu commented Mar 29, 2018

Add a missing lock acquisition around access to queued_control_events
in control_free_all(). Use the reassign-and-unlock strategy as in
queued_events_flush_all(). Fixes bug 25675. Coverity found this bug,
but only after we recently added an access to
flush_queued_event_pending.
@tlyu
Fix CID 1433643
596eed3 
Add a missing lock acquisition around access to queued_control_events
in control_free_all().  Use the reassign-and-unlock strategy as in
queued_events_flush_all().  Fixes bug 25675.  Coverity found this bug,
but only after we recently added an access to
flush_queued_event_pending.
@tor-bot tor-bot merged commit 596eed3 into torproject:master Mar 30, 2018
1 check passed
@tlyu tlyu deleted the bug25675 branch Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment