Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rust dependency updating (trac #27130) #347

Closed
wants to merge 3 commits into from
Closed

fix rust dependency updating (trac #27130) #347

wants to merge 3 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tlyu @coveralls @torproject-pusher
@tlyu
Copy link
Contributor

@tlyu tlyu commented Sep 17, 2018

No description provided.

cypherpunks added 3 commits Aug 13, 2018
add missing exit on error in rust/cargo vendoring script
03803c2
fix rust dependency updating instructions
dd6ac76 
None of the instructions mentioned the key step of updating
Cargo.lock, which the script updateRustDependencies.sh didn't do,
because it used `--locked`. Unless Cargo.lock was already updated
to newer dependencies, the script refuses to do anything at all.

Make sure the commit that updates Cargo.lock is the same commit
that updates the hash for the git submodule.
rust: drop '=' exact version requirements
ee91c91 
Undo the exact-version requirements added in
00a4737.

Maintaining a predictable version that's always used
is what Cargo.lock is for.

Remove instructions that imply this is necessary from
9799394.
@coveralls
Copy link

@coveralls coveralls commented Sep 17, 2018

Coverage Status

Coverage increased (+0.001%) to 61.824% when pulling ee91c91 on tlyu:cyberpunks-rustdep1 into f606b3c on torproject:master.

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment