Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug23512 v4 033 (merge to 0.3.4) #351

Closed

Conversation

Labels
None yet
Projects
None yet
3 participants
@mikeperry-tor
Copy link
Contributor

@mikeperry-tor mikeperry-tor commented Sep 17, 2018

Additional pull request for 0.3.4. Merged branch is identical to 033 version; PR created for to run 0.3.4's tests.

The rest of rephist uses uint64_t internally. Let's make these take it too,
so we don't have to worry about overflowing size_t on 32 bit systems.
This avoids asymmetry in our public relay stats, which can be exploited for
guard discovery and other attacks.
This mocking was not available in 0.2.9.
Duplicate comes from introducing this define into 0.2.9, which did not yet
have KIST.
@coveralls
Copy link

@coveralls coveralls commented Sep 18, 2018

Coverage Status

Coverage increased (+0.09%) to 59.642% when pulling ad10caf on mikeperry-tor:bug23512-v4-033 into 6f47734 on torproject:maint-0.3.4.

@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 30, 2018

A version of this was squashed and merged; see tickets for subsequent developments

@nmathewson nmathewson closed this Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment