Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make crypto_strongest_rand() non-mockable #354

Merged
merged 1 commit into from Oct 1, 2018
Merged

Make crypto_strongest_rand() non-mockable #354

merged 1 commit into from Oct 1, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 18, 2018

Instead, have it call a mockable function. We don't want
crypto_strongest_rand() to be mockable, since doing so creates a
type error when we call it from ed25519-donna, which we do not build
in a test mode.

Fixes bug 27728; bugfix on 0.3.5.1-alpha
@nmathewson
Make crypto_strongest_rand() non-mockable
ea5792f 
Instead, have it call a mockable function.  We don't want
crypto_strongest_rand() to be mockable, since doing so creates a
type error when we call it from ed25519-donna, which we do not build
in a test mode.

Fixes bug 27728; bugfix on 0.3.5.1-alpha
@coveralls
Copy link

@coveralls coveralls commented Sep 18, 2018

Coverage Status

Coverage increased (+0.002%) to 61.887% when pulling ea5792f on nmathewson:bug27728 into 50367d0 on torproject:master.

@torproject-pusher torproject-pusher merged commit ea5792f into torproject:master Oct 1, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment