Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hs-v3: Consolidate descriptor cookie computation code #355

Closed
wants to merge 2 commits into from
Closed

hs-v3: Consolidate descriptor cookie computation code #355

wants to merge 2 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@dgoulet-tor @coveralls @nmathewson @asn-d6
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Sep 18, 2018

Both client and service had their own code for this. Consolidate into one
place so we avoid duplication.

Closes #27549

Signed-off-by: David Goulet dgoulet@torproject.org
@dgoulet-tor
hs-v3: Consolidate descriptor cookie computation code
d940bfd 
Both client and service had their own code for this. Consolidate into one
place so we avoid duplication.

Closes #27549

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Sep 18, 2018 •
edited

Coverage Status

Coverage increased (+0.09%) to 61.976% when pulling 573a38a on dgoulet-tor:ticket27549_035_01 into 50367d0 on torproject:master.

@asn-d6 @dgoulet-tor
fixup! hs-v3: Consolidate descriptor cookie computation code
573a38a 
The helper functions were not reducing LOCs or helping with abstraction
since the calling function still had to know the structure of KEYS to do
the memcpy. Let's just kill the helper functions to make the patch easier.
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Oct 18, 2018

Squashed and merged

@nmathewson nmathewson closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment