Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Make node_supports_v3_rendezvous_point() also check for the key #361

Merged
merged 1 commit into from Sep 21, 2018
Merged

node: Make node_supports_v3_rendezvous_point() also check for the key #361

merged 1 commit into from Sep 21, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dgoulet-tor @coveralls @torproject-pusher
@dgoulet-tor
Copy link
Contributor

@dgoulet-tor dgoulet-tor commented Sep 20, 2018

It is not enough to look at protover for v3 rendezvous support but also we
need to make sure that the curve25519 onion key is present or in other words
that the descriptor has been fetched and does contain it.

Fixes #27797.

Signed-off-by: David Goulet dgoulet@torproject.org
@dgoulet-tor
node: Make node_supports_v3_rendezvous_point() also check for the key
e3713f1 
It is not enough to look at protover for v3 rendezvous support but also we
need to make sure that the curve25519 onion key is present or in other words
that the descriptor has been fetched and does contain it.

Fixes #27797.

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Sep 20, 2018

Coverage Status

Coverage decreased (-0.002%) to 61.892% when pulling e3713f1 on dgoulet-tor:ticket27797_035_01 into 1191596 on torproject:master.

@torproject-pusher torproject-pusher merged commit e3713f1 into torproject:master Sep 21, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment