New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket27849 034 01 #374

Closed
wants to merge 11 commits into
base: maint-0.3.4
from

Conversation

Projects
None yet
3 participants
@dgoulet-tor
Contributor

dgoulet-tor commented Sep 26, 2018

No description provided.

dgoulet-tor added some commits Jul 3, 2018

mainloop: Set client role if ControlPort is set
It turns out that if _only_ the ControlPort is set and nothing else, tor would
simply not bootstrap and thus not start properly. Commit 67a41b6
removed that requirement for tor to be considered a "client".

Unfortunately, this made the mainloop enable basically nothing if only the
ControlPort is set in the torrc.

This commit now makes it that we also consider the ControlPort when deciding
if we are a Client or not. It does not revert 67a41b6 meaning
options_any_client_port_set() stays the same, not looking at the control port.

Fixes #27849.

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls

This comment has been minimized.

coveralls commented Sep 26, 2018

Coverage Status

Coverage increased (+0.001%) to 59.553% when pulling 7a810fa on dgoulet-tor:ticket27849_034_01 into ffaf180 on torproject:maint-0.3.4.

@nmathewson

This comment has been minimized.

Contributor

nmathewson commented Oct 16, 2018

Cherry-picked, squashed, and merged

@nmathewson nmathewson closed this Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment