Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split stats #376

Merged
merged 8 commits into from Sep 27, 2018
Merged

Split stats #376

merged 8 commits into from Sep 27, 2018

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@nmathewson @coveralls @dgoulet-tor @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Sep 27, 2018

No description provided.

nmathewson added 6 commits Sep 27, 2018
@nmathewson
Move the predicted ports code out of rephist.c
241c150 
It differs from the rest of the rephist code in that it's actually
necessary for Tor to operate, so it should probably go somewhere
else.  I'm not sure where yet, so I'll leave it in the same
directory, but give it its own file.
@nmathewson
Move the n_v3_ns_requests field out of geoip_country_t
79208ee 
This is preparation for splitting geoip.c into stats and non-stats
portions.
@nmathewson
Split geoip from geoip-related stats.
f403af2 
This commit just moves the code to two separate files. The geoip
code still has a few needless dependencies on core/* and features/*.
@nmathewson
Remove excess dependencies from geoip.c
fa32574
@nmathewson
Extract the non-stats part of geoip into a new src/lib/geoip.
c8f2a6d
@nmathewson
Changes file for splitting stats
013a123
@coveralls
Copy link

@coveralls coveralls commented Sep 27, 2018 •
edited

Coverage Status

Coverage decreased (-0.1%) to 61.813% when pulling 3164530 on nmathewson:split_stats into de0b07c on torproject:master.

nmathewson added 2 commits Sep 27, 2018
@nmathewson
geoip: fix windows compilation
34402ec
@nmathewson
Mark a variable static.
3164530
dgoulet-tor
dgoulet-tor reviewed Sep 27, 2018
View changes
src/feature/stats/geoip.c
geoip_country_t *country = smartlist_get(geoip_countries, country_idx);
++country->n_v3_ns_requests;
}
increment_v3_ns_request(country_idx);
Copy link
Contributor

@dgoulet-tor dgoulet-tor Sep 27, 2018

So hmmm country_idx is a integer but this function expects a country_t which is a typedef to uint16_t. I do see a overflow issue but of course if 65535 countries would exists so unlikely but still, I think we should fix that.

@torproject-pusher torproject-pusher merged commit 3164530 into torproject:master Sep 27, 2018
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment