Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug27968 SIGNAL HALT race condition in test-rebind.py #386

Closed
wants to merge 3 commits into from
Closed

Bug27968 SIGNAL HALT race condition in test-rebind.py #386

wants to merge 3 commits into from

Conversation

Reviewers

@tlyu tlyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@teor-travel @coveralls @tlyu @torproject-pusher @teor2345
@teor-travel
Copy link

@teor-travel teor-travel commented Oct 6, 2018

See https://trac.torproject.org/projects/tor/ticket/27968
teor2345 added 3 commits Oct 6, 2018
@teor2345
Avoid a race condition in test_rebind.py
e4cf8cb 
If tor terminates due to SIGNAL HALT before test_rebind.py calls
tor_process.terminate(), an OSError 3 (no such process) is thrown.

Fixes part of bug 27968 on 0.3.5.1-alpha.
@teor2345
Refactor test_rebind.py to consistently print FAIL on failure
e56e919 
Part of #27968.
@teor2345
Make test_rebind.py timeout when waiting for a log message
6a1f51a 
Closes #27968.
@coveralls
Copy link

@coveralls coveralls commented Oct 6, 2018

Coverage Status

Coverage decreased (-0.01%) to 61.957% when pulling 6a1f51a on teor-travel:bug27968 into 43211c3 on torproject:master.

tlyu
tlyu reviewed Oct 11, 2018
View changes
src/test/test_rebind.py
try:
tor_process.terminate()
except OSError as e:
if e.errno == 3: # No such process
Copy link
Contributor

@tlyu tlyu Oct 11, 2018

This should probably use the symbolic name from the errno module instead of hard coding a number.

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment