Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27913: Try running test-stem on travis #387

Closed
wants to merge 3 commits into from

Conversation

Labels
None yet
Projects
None yet
3 participants
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Oct 7, 2018

https://trac.torproject.org/projects/tor/ticket/27913

@coveralls
Copy link

@coveralls coveralls commented Oct 7, 2018

Coverage Status

Coverage increased (+0.001%) to 61.971% when pulling 3afe83d on rl1987:travis_test_stem into 43211c3 on torproject:master.

.travis.yml Outdated
@@ -191,6 +193,7 @@ script:
- ./configure $CONFIGURE_FLAGS
## We run `make check` because that's what https://jenkins.torproject.org does.
- if [[ "$DISTCHECK" == "" ]]; then make check; fi
- if [[ "$TEST_STEM" != "" ]]; then git clone https://git.torproject.org/stem.git/ ; export STEM_SOURCE_DIR=`pwd`/stem; make test-stem; fi
Copy link
Contributor

@tlyu tlyu Oct 11, 2018

Could we maybe use the github.com mirror instead? That way we could be more robust against network connectivity problems. (Travis already needs to be able to reach github.com to start the build.)

Also, maybe use git clone --depth 1 to speed things up? We don't need the full git history of stem for this test, as far as I know.

Needs a changes file.

Copy link
Contributor Author

@rl1987 rl1987 Oct 12, 2018

Fixed git clone command in 31812e5 and added changes file in 3afe83d.

@rl1987 rl1987 closed this Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment