#27913: Try running test-stem on Travis (2) #399
Conversation
rl1987
changed the title
.travis.yml
Outdated
| @@ -200,6 +202,7 @@ script: | |||
| - ./configure $CONFIGURE_FLAGS | |||
| ## We run `make check` because that's what https://jenkins.torproject.org does. | |||
| - if [[ "$DISTCHECK" == "" ]]; then make check; fi | |||
I just noticed this job takes significantly longer to run, so maybe we could skip the make check when we're doing make test-stem? We'd probably want to do something like make all && make test-stem though to avoid parallelization problems.
+1
I wish we could fix the parallelisation problems, but that's a separate issue that deserves a separate ticket. (And they're so hard to debug.)
I suggest make src/app/tor, unless test-stem uses some of the other build products.
(Oops, this is teor, I am logged into the wrong account.)
Did these things and build takes less time now.
When running `make test-stem` on Travis, we should refrain from also running `make check`. Furthermore, let's limit compilation to src/app/tor target.
.travis.yml
Outdated
| @@ -199,7 +201,8 @@ script: | |||
| - echo "Configure flags are $CONFIGURE_FLAGS" | |||
| - ./configure $CONFIGURE_FLAGS | |||
| ## We run `make check` because that's what https://jenkins.torproject.org does. | |||
| - if [[ "$DISTCHECK" == "" ]]; then make check; fi | |||
| - if [[ "$DISTCHECK" == "" && "$TEST_STEM" == "" ]]; then make check; fi | |||
| - if [[ "$TEST_STEM" != "" ]]; then git clone --depth 1 https://github.com/torproject/stem.git ; export STEM_SOURCE_DIR=`pwd`/stem; make src/app/tor test-stem; fi | |||
Technically, git clone stem belongs in the install section.
We also do our environmental variable setup in install.
Please also log the stem version. I think git clone already logs the stem commit.
It seems like distcheck and test-stem are incompatible, because distcheck deletes src/app/tor.
If both options are specified, should we skip stem and log a message?
Nitpick: I'd like to see test stem added as the last item in both sections, but it doesn't really matter.
These are addressed in further commits now. Opened a new pull request with rebased branch and cleaned up git history: #423
Also print stem version when we have it downloaded
https://trac.torproject.org/projects/tor/ticket/27913
The text was updated successfully, but these errors were encountered: