Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticket 27800-033: Log more info for duplicate ed25519 IDs #412

Merged
merged 1 commit into from Oct 18, 2018
Merged

ticket 27800-033: Log more info for duplicate ed25519 IDs #412

merged 1 commit into from Oct 18, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tlyu @coveralls @torproject-pusher
@tlyu
Copy link
Contributor

@tlyu tlyu commented Oct 17, 2018

Occasionally, key pinning doesn't catch a relay that shares an ed25519
ID with another relay. Log the identity fingerprints and the shared
ed25519 ID when this happens, instead of making a BUG() warning.

Fixes bug 27800; bugfix on 0.3.2.1-alpha.
@tlyu
Log more info for duplicate ed25519 IDs
93fd924 
Occasionally, key pinning doesn't catch a relay that shares an ed25519
ID with another relay.  Log the identity fingerprints and the shared
ed25519 ID when this happens, instead of making a BUG() warning.

Fixes bug 27800; bugfix on 0.3.2.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Oct 17, 2018

Coverage Status

Coverage increased (+0.02%) to 57.902% when pulling 93fd924 on tlyu:bug27800-033 into ec638e2 on torproject:release-0.3.3.

@torproject-pusher torproject-pusher merged commit 93fd924 into torproject:release-0.3.3 Oct 18, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment