Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket27471 035 01 #414

Closed
wants to merge 3 commits into from
Closed

Ticket27471 035 01 #414

wants to merge 3 commits into from

Conversation

Labels
None yet
Projects
None yet
4 participants
@asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Oct 17, 2018

No description provided.

dgoulet-tor and others added 3 commits Oct 12, 2018
When storing a descriptor in the client cache, if we are about to replace an
existing descriptor, make sure to close every introduction circuits of the old
descriptor so we don't have leftovers lying around.

Ticket 27471 describes a situation where tor is sending an INTRODUCE1 cell on
an introduction circuit for which it doesn't have a matching intro point
object (taken from the descriptor).

The main theory is that, after a new descriptor showed up, the introduction
points changed which led to selecting an introduction circuit not used by the
service anymore thus for which we are unable to find the corresponding
introduction point within the descriptor we just fetched.

Closes #27471.

Signed-off-by: David Goulet <dgoulet@torproject.org>
This is client side and related to 27471 for previous commit that fixes this
issue.

Signed-off-by: David Goulet <dgoulet@torproject.org>
@coveralls
Copy link

@coveralls coveralls commented Oct 18, 2018

Coverage Status

Coverage increased (+0.06%) to 62.032% when pulling 3dd5152 on asn-d6:ticket27471_035_01 into fd2e0ac on torproject:master.

@torproject-pusher torproject-pusher deleted the branch torproject:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment