Don't overwrite the Content-Type when compressing #420
Conversation
Pull Request Test Coverage Report for Build 2719
|
teor2345
suggested changes
Oct 30, 2018
Looks fine to me, but we could tweak the comment so it's more readable.
src/feature/dircache/dircache.c
Outdated
| @@ -166,22 +166,16 @@ write_http_response_header_impl(dir_connection_t *conn, ssize_t length, | |||
| buf_free(buf); | |||
| } | |||
|
|
|||
| /** As write_http_response_header_impl, but sets encoding and content-typed | |||
| * based on whether the response will be <b>compressed</b> or not. */ | |||
| /** As write_http_response_header_impl, but translates compress_method_t into | |||
The argument name also changes from method to encoding`.
So let's say:
Suggested change
| /** As write_http_response_header_impl, but translates compress_method_t into | |
| /** As write_http_response_header_impl, but translates method into |
You can keep the types as well if you want.
src/feature/dircache/dircache.c
Outdated
| /** As write_http_response_header_impl, but sets encoding and content-typed | ||
| * based on whether the response will be <b>compressed</b> or not. */ | ||
| /** As write_http_response_header_impl, but translates compress_method_t into | ||
| * const char * */ |
Suggested change
| * const char * */ | |
| * encoding */ |
|
test-stem is now active on master's CI: Closing and re-opening to re-run the merged branch. |
teor2345
approved these changes
Nov 1, 2018
|
squashed and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://trac.torproject.org/projects/tor/ticket/28100
The text was updated successfully, but these errors were encountered: