Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21900: Fallback to local DNS when no other nameservers are known (2) #425

Merged
merged 7 commits into from Oct 30, 2018
Merged

#21900: Fallback to local DNS when no other nameservers are known (2) #425

merged 7 commits into from Oct 30, 2018

Conversation

Reviewers

@nmathewson nmathewson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rl1987 @coveralls @nmathewson @torproject-pusher
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Oct 20, 2018

https://trac.torproject.org/projects/tor/ticket/21900
rl1987 added 6 commits Oct 20, 2018
@rl1987
Fallback to local DNS when no other nameservers are known
91fa12a
@rl1987
Mention DNS fallback in manpage
98fd3b4
@rl1987
Add changes file
1a1b088
@rl1987
Unit test for DNS fallback in configure_nameservers
d827902
@rl1987
Check if libevent comes with evdns_base_get_nameserver_addr()
92f0e04
@rl1987
Exclude test and a supporting function when evdns_base_get_nameserver…
98cef68 
…_addr() is not available
@rl1987 rl1987 changed the title #21900: Fallback to local DNS when no other nameservers are known #21900: Fallback to local DNS when no other nameservers are known (2) Oct 20, 2018
@coveralls
Copy link

@coveralls coveralls commented Oct 20, 2018 •
edited

Pull Request Test Coverage Report for Build 2602

  • 0 of 22 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 62.041%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/relay/dns.c 0 22 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/relay/dns.c 1 17.89%
Totals Coverage Status
Change from base Build 2522: 0.03%
Covered Lines: 44091
Relevant Lines: 71068
💛 - Coveralls

nmathewson
nmathewson reviewed Oct 23, 2018
View changes
src/feature/relay/dns.c Outdated
(struct sockaddr *)&sa,
sa_len) > 0) {
tor_addr_t *tor_addr = tor_malloc(sizeof(tor_addr_t));
tor_addr_from_sockaddr(tor_addr, (const struct sockaddr *)&sa, NULL);
Copy link
Contributor

@nmathewson nmathewson Oct 23, 2018

This call is allowed to fail; we need to check its return value.

Copy link
Contributor Author

@rl1987 rl1987 Oct 26, 2018

Fixed in b7edfcb.

@rl1987
In configured_nameserver_address, check if tor_addr_from_sockaddr suc…
b7edfcb 
…ceeded
@torproject-pusher torproject-pusher merged commit b7edfcb into torproject:master Oct 30, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment