Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust/protover: reject extra commas #428

Open
wants to merge 2 commits into
base: maint-0.3.3
Choose a base branch
from
Open

rust/protover: reject extra commas #428

wants to merge 2 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @coveralls
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 22, 2018

The C implementation had gotten this wrong too, in a slightly different way.

Introduced in 5af03c1.

Fixes #27197; bugfix on 0.3.3.3-alpha.
cypherpunks added 2 commits Sep 15, 2018
rust/protover: reject extra commas
1ed5e00 
The C implementation had gotten this wrong too, in a slightly different way.

Introduced in 5af03c1.

Fixes #27197; bugfix on 0.3.3.3-alpha.
rust/protover: remove redundant ExceedsMax checks
b91bc1b 
This is already checked elsewhere.
@teor2345 teor2345 closed this Nov 6, 2018
@teor2345 teor2345 reopened this Nov 6, 2018
@coveralls
Copy link

@coveralls coveralls commented Nov 6, 2018

Pull Request Test Coverage Report for Build 2810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 305 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 57.919%
Files with Coverage Reduction New Missed Lines %
src/or/hs_common.c 1 83.55%
src/or/connection_edge.c 304 18.77%
Totals Coverage Status
Change from base Build 2496: 0.01%
Covered Lines: 40275
Relevant Lines: 69537
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment