New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: correctly identify relays running on Windows 8, 8.1, and 10 #429

wants to merge 1 commit into
base: maint-0.2.9


None yet
2 participants
Copy link

teor2345 commented Oct 22, 2018

Correctly identify Windows 8.1 and Windows 10 (or later) when tor
is launched with a Windows application compatibility manifest for these
versions of Windows.

When tor is not launched with a manifest (the default), report
"Windows 8 or later".

Fixes bug 28096; bugfix on; reported by Keifer Bly.

Windows: fix uname on recent Windows versions
Correctly identify Windows 8.1, Windows 10, and Windows Server 2008
and later from their NT versions.

On recent Windows versions, the GetVersionEx() function may report
an earlier Windows version than the running OS. To avoid user
confusion, add "[or later]" to Tor's version string on affected
versions of Windows.

Remove Windows versions that were never supported by the
GetVersionEx() function.

Stop duplicating the latest Windows version in get_uname().

Fixes bug 28096; bugfix on; reported by Keifer Bly.

@teor2345 teor2345 force-pushed the teor2345:bug28096-029 branch from bbd7cda to 9abf385 Nov 4, 2018


This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Pull Request Test Coverage Report for Build 2784

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.003%) to 49.966%

Files with Coverage Reduction New Missed Lines %
src/ext/trunnel/trunnel.c 1 34.48%
src/or/channel.h 2 0.0%
src/or/circuitstats.c 2 73.71%
Totals Coverage Status
Change from base Build 2714: -0.003%
Covered Lines: 29402
Relevant Lines: 58844

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment