New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug28096 035 #430

wants to merge 4 commits into
base: master


None yet
2 participants
Copy link

teor2345 commented Oct 22, 2018

  Correctly identify Windows 8.1 and Windows 10 (or later) when tor
  is launched with a Windows application compatibility manifest for these
  versions of Windows. When tor is not launched with a manifest
  (the default), report "Windows 8 or later".
  Fixes bug 28096; bugfix on; reported by Keifer Bly.

teor2345 added some commits Oct 22, 2018

Windows: fix uname on recent Windows versions
Correctly identify Windows 8.1, Windows 10, and Windows Server 2008
and later from their NT versions.

On recent Windows versions, the GetVersionEx() function may report
an earlier Windows version than the running OS. To avoid user
confusion, add "[or later]" to Tor's version string on affected
versions of Windows.

Remove Windows versions that were never supported by the
GetVersionEx() function.

Stop duplicating the latest Windows version in get_uname().

Fixes bug 28096; bugfix on; reported by Keifer Bly.
Merge branch 'bug28096-029' into bug28096-035
Copy the changes to get_uname() from compat.c to uname.c.

@teor2345 teor2345 force-pushed the teor2345:bug28096-035 branch from f5a0cd1 to 3e8a562 Nov 4, 2018


This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Pull Request Test Coverage Report for Build 2797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 62.053%

Totals Coverage Status
Change from base Build 2775: 0.02%
Covered Lines: 44125
Relevant Lines: 71109

💛 - Coveralls

teor2345 added some commits Nov 5, 2018

Merge branch 'bug28096-029' into bug28096-035
Move the fixup over to src/lib/osinfo/uname.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment