[Tor Trac #28127]: Hidden service option HiddenServiceAuthorizeClient is incompatible with version 3 #435
Conversation
…nless we have set HiddenServiceVersion
Pull Request Test Coverage Report for Build 2622
|
dgoulet-tor
reviewed
Oct 29, 2018
| * present and we did not set HiddenServiceVersion. Depending on the key | ||
| * format, we can figure out the service version. */ | ||
| if (!service->config.hs_version_explicitly_set) | ||
| service->config.version = config_learn_service_version(service); |
We try to always put the {} even if this pattern is everywhere in the code base.
src/feature/hs/hs_config.c
Outdated
| @@ -577,16 +581,20 @@ config_service(const config_line_t *line, const or_options_t *options, | |||
| tor_assert_nonfatal_unreached(); | |||
| goto err; | |||
| } | |||
|
|
|||
Lets not remove this whitespace. The reason is that the if(ret < 0) being glued to the switch condition is to reflect that they are linked together and that adding anything in between is probably a bad idea.
src/feature/hs/hs_service.h
Outdated
| @@ -220,6 +220,9 @@ typedef struct hs_service_config_t { | |||
| /* Is this service ephemeral? */ | |||
| unsigned int is_ephemeral : 1; | |||
|
|
|||
| /* Have we explicitly set HiddenServiceVersion? */ | |||
| unsigned int hs_version_explicitly_set : 1; | |||
|
|
|||
Super nitpick here: Can you put that next to the version so we have the parameters from the same context next to each other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
For the bug here.
The text was updated successfully, but these errors were encountered: