Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug28202 029 #442

Merged
merged 2 commits into from Oct 29, 2018
Merged

Bug28202 029 #442

merged 2 commits into from Oct 29, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Oct 25, 2018

No description provided.

nmathewson added 2 commits Oct 25, 2018
@nmathewson
Fix possible UB in an end-of-string check in get_next_token().
368413a 
Remember, you can't check to see if there are N bytes left in a
buffer by doing (buf + N < end), since the buf + N computation might
take you off the end of the buffer and result in undefined behavior.

Fixes 28202; bugfix on 0.2.0.3-alpha.
@nmathewson
Fix two other cases of (buf + N > end) pattern
0878bb9 
Related to fix for 28202.
@coveralls
Copy link

@coveralls coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 2592

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0009%) to 49.967%
Totals Coverage Status
Change from base Build 2441: -0.0009%
Covered Lines: 29398
Relevant Lines: 58835
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 0878bb9 into torproject:maint-0.2.9 Oct 29, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment