Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] #27201 Rust protozero1 merge 0.3.3 #456

Open
wants to merge 3 commits into
base: maint-0.3.3
Choose a base branch
from
Open

[WIP] #27201 Rust protozero1 merge 0.3.3 #456

wants to merge 3 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @coveralls
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 30, 2018

Don't merge, we are still sorting out spec issues.
cypherpunks added 3 commits Sep 15, 2018
rust/protover: reject extra commas
1ed5e00 
The C implementation had gotten this wrong too, in a slightly different way.

Introduced in 5af03c1.

Fixes #27197; bugfix on 0.3.3.3-alpha.
rust/protover: remove redundant ExceedsMax checks
b91bc1b 
This is already checked elsewhere.
rust/protover: reject version zero
5bf37b3
@coveralls
Copy link

@coveralls coveralls commented Oct 30, 2018

Pull Request Test Coverage Report for Build 2661

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 57.917%
Files with Coverage Reduction New Missed Lines %
src/or/circuitstats.c 7 77.99%
Totals Coverage Status
Change from base Build 2636: 0.003%
Covered Lines: 40273
Relevant Lines: 69536
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment