Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptive padding rebased 0.3.6 pr547 squashed #575

Closed
wants to merge 29 commits into from
Closed

Adaptive padding rebased 0.3.6 pr547 squashed #575

wants to merge 29 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mikeperry-tor @coveralls @asn-d6
@mikeperry-tor
Copy link
Contributor

@mikeperry-tor mikeperry-tor commented Dec 7, 2018

No description provided.

mikeperry-tor and others added 29 commits Nov 30, 2018
@mikeperry-tor
Provide a smartlist reverse-order traversal.
3165c8c 
We need this for padding negotiation so that we can have later machine
revisions supercede earlier ones.
@mikeperry-tor
Circuit padding header.
78fc531 
This is a good code review start point, to get an overview of the interfaces
and types used in circuit padding.
@mikeperry-tor
Hook up circuit padding to circuit_t.
7ba4aec
@mikeperry-tor
Initialize circuit padding machines and global state.
538b918
@mikeperry-tor
Circuit padding ProtoVer plumbing.
62921d4 
This helps us to determine if a middle node can pad to us or not.
@mikeperry-tor
Add padding negotiation trunnel output.
47dd52a
@mikeperry-tor
Circuit padding machine creation events.
fda9af5 
These event callbacks allow circuit padding to decide when to attempt to
launch and negotiate new padding machines, and when to tear old ones down.
@mikeperry-tor
Circuit padding cell event callbacks.
cebd327 
These callbacks allow the padding state machines to react to various types of
sent and received relay cells.
@mikeperry-tor
Circuit padding implementation.
18a6be9 
This implements all of the event handling, state machines, and padding
decisions for circuit padding.

I recommend reviewing this after you look at the call-in points into it from
the rest of Tor.
@mikeperry-tor
Improve circpad_distribution_sample() accuracy.
a73c3a2 
* Tighten and justify cutoff for approximation in GPD sampler.
* Use expm1(-xi log U) to evaluate U^{-xi} - 1 without precision loss.
* Use log1p(x) to evaluate log(1 + x) precisely even for x near 0.
* Avoid 0 by rejection sampling, not by choosing to return 0 instead.
  (This avoids the problematic 0 return from crypto_rand_double()
   into the log() without introducing distribution bias).
@mikeperry-tor
Add relay crypto mock points for tests.
0fac036
@mikeperry-tor
Circuit padding tests.
1bdcfa5
@mikeperry-tor
Config option to specify specific MiddleNodes.
98bae23 
Hope is this will make it easier to test on the live tor network.

Does not need to be merged if we don't want to, but will come in handy
for researchers.
@mikeperry-tor
Add TODO file for padding work.
d860abc 
Note to self/others: don't merge this.
@asn-d6 @mikeperry-tor
Implement and test probability distributions used by WTF-PAD.
9682f42 
This project introduces the prob_distr.c subsystem which implements all the
probability distributions that WTF-PAD needs. It also adds unittests for all of
them.

Code and tests courtesy of Riastradh.

Co-authored-by: Taylor R Campbell <campbell+tor@mumble.net>
@asn-d6 @mikeperry-tor
Use the new probability distribution code in WTF-PAD.
6d9d566 
Also add some basic tests for sampling delays from the uniform distribution.
@asn-d6 @mikeperry-tor
Test SMARTLIST_FOREACH_REVERSE_BEGIN
4c44d7b
@asn-d6 @mikeperry-tor
Test padding rate limits.
5637612
@mikeperry-tor
fixup! Circuit padding header.
da85e7d 
Tighten up integer-like type usage.
@mikeperry-tor
fixup! Circuit padding implementation.
000f36b 
Tighten up integer type usage.
@mikeperry-tor
fixup! Circuit padding tests.
60ba5c2 
Tighten up type usage.
@mikeperry-tor
fixup! Add TODO file for padding work.
ba9be22
@asn-d6 @mikeperry-tor
fixup! Test padding rate limits.
32c1928
@asn-d6 @mikeperry-tor
Better test of circpad_machine_remove_closest_token().
55aff5a
@asn-d6 @mikeperry-tor
Test of circpad_machine_remove_exact().
d955fa6
@mikeperry-tor
fixup! Better test of circpad_machine_remove_closest_token().
c63945c 
Use new type for bin.
@mikeperry-tor
fixup! Circuit padding tests.
dd89894 
Fix a return type issue.
@mikeperry-tor
fixup! Circuit padding implementation.
bceed63 
Fix a return type issue.
@mikeperry-tor
fixup! Circuit padding header.
b5e2fdf 
Fix a return type issue.
@coveralls
Copy link

@coveralls coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 3229

  • 842 of 992 (84.88%) changed or added relevant lines in 13 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 61.108%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/config/config.c 1 2 50.0%
src/feature/nodelist/routerlist.c 1 2 50.0%
src/core/or/circuituse.c 3 5 60.0%
src/core/or/connection_edge.c 0 2 0.0%
src/lib/math/prob_distr.c 206 208 99.04%
src/core/or/relay.c 4 11 36.36%
src/core/or/circuitbuild.c 2 13 15.38%
src/core/or/circuitpadding.c 616 740 83.24%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitbuild.c 2 42.12%
Totals Coverage Status
Change from base Build 3214: 0.0%
Covered Lines: 44310
Relevant Lines: 72511
💛 - Coveralls

@asn-d6 asn-d6 closed this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment