Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the core of parse_short_policy() to be faster. #592

Merged
merged 1 commit into from Dec 19, 2018
Merged

Rewrite the core of parse_short_policy() to be faster. #592

merged 1 commit into from Dec 19, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Dec 14, 2018

The old implementation did some funky out-of-order lexing, and
tended to parse every port twice if the %d-%d pattern didn't match.

Closes ticket 28853.
@nmathewson
Rewrite the core of parse_short_policy() to be faster.
3dd1f06 
The old implementation did some funky out-of-order lexing, and
tended to parse every port twice if the %d-%d pattern didn't match.

Closes ticket 28853.
@coveralls
Copy link

@coveralls coveralls commented Dec 14, 2018

Pull Request Test Coverage Report for Build 3300

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.799%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.94%
Totals Coverage Status
Change from base Build 3287: -0.02%
Covered Lines: 43527
Relevant Lines: 71592
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 3dd1f06 into torproject:master Dec 19, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment