Adaptive padding rebased 0.3.6 pr547 squashed appveyor fixes #593
Conversation
We need this for padding negotiation so that we can have later machine revisions supercede earlier ones.
This is a good code review start point, to get an overview of the interfaces and types used in circuit padding.
This helps us to determine if a middle node can pad to us or not.
These event callbacks allow circuit padding to decide when to attempt to launch and negotiate new padding machines, and when to tear old ones down.
These callbacks allow the padding state machines to react to various types of sent and received relay cells.
This implements all of the event handling, state machines, and padding decisions for circuit padding. I recommend reviewing this after you look at the call-in points into it from the rest of Tor.
* Tighten and justify cutoff for approximation in GPD sampler.
* Use expm1(-xi log U) to evaluate U^{-xi} - 1 without precision loss.
* Use log1p(x) to evaluate log(1 + x) precisely even for x near 0.
* Avoid 0 by rejection sampling, not by choosing to return 0 instead.
(This avoids the problematic 0 return from crypto_rand_double()
into the log() without introducing distribution bias).
Hope is this will make it easier to test on the live tor network. Does not need to be merged if we don't want to, but will come in handy for researchers.
Note to self/others: don't merge this.
This project introduces the prob_distr.c subsystem which implements all the probability distributions that WTF-PAD needs. It also adds unittests for all of them. Code and tests courtesy of Riastradh. Co-authored-by: Taylor R Campbell <campbell+tor@mumble.net>
Also add some basic tests for sampling delays from the uniform distribution.
Tighten up integer-like type usage.
Tighten up integer type usage.
Tighten up type usage.
Use new type for bin.
Fix a return type issue.
Fix a return type issue.
Fix a return type issue.
- Break down macro stringification into multiple steps because mingw was failing to understand format string arugments. - Convert printf to log_warn.
Fix issues found in conditions test.
Expose machine list.
Fix a bug with cell event delivery. It was completely broken due to typo..
Implement conditions test and tweak some other tests for coverage.
Disable all serialization code.
Tweak some tests for increased coverage.
Coverage for lower bin case of closest_usec.
Update test lists. Getting closer!
Pull Request Test Coverage Report for Build 3302
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.
The text was updated successfully, but these errors were encountered: