Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket28856 v2: Eliminate strcmp_len(). #596

merged 2 commits into from Jan 9, 2019


None yet
3 participants
Copy link

commented Dec 17, 2018

No description provided.

nmathewson added some commits Dec 17, 2018

Replace use of strcmp_len() with new mem_eq_token().
The strcmp_len() function was somewhat misconceived, since we're
only using it to test whether a length+extent string is equal to a
NUL-terminated string or not.  By simplifying it and making it
inlined, we should be able to make it a little faster.

(It *does* show up in profiles.)

Closes ticket 28856.

This comment has been minimized.

Copy link

commented Dec 17, 2018

Pull Request Test Coverage Report for Build 3308

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.796%

Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.94%
Totals Coverage Status
Change from base Build 3287: -0.02%
Covered Lines: 43524
Relevant Lines: 71590

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 2925481 into torproject:master Jan 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.