Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always initialize addr in parse_port_config() #599

Closed
wants to merge 1 commit into from
Closed

Always initialize addr in parse_port_config() #599

wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nmathewson @coveralls
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Dec 17, 2018

It was always analyzed before use, but scan-build wasn't able to
persuade itself of that.

Closes ticket 28881.
@nmathewson
Always initialize addr in parse_port_config()
acd3e3b 
It was always analyzed before use, but scan-build wasn't able to
persuade itself of that.

Closes ticket 28881.
@coveralls
Copy link

@coveralls coveralls commented Dec 17, 2018

Pull Request Test Coverage Report for Build 3311

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.315%
Files with Coverage Reduction New Missed Lines %
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.79%
Totals Coverage Status
Change from base Build 3288: -0.02%
Covered Lines: 42850
Relevant Lines: 71044
💛 - Coveralls

@nmathewson
Copy link
Contributor Author

@nmathewson nmathewson commented Dec 18, 2018

Merged a version with a typo fix in the changes file

@nmathewson nmathewson closed this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment