Adaptive padding rebased 0.3.6 pr547 squashed final rebase squashed #601

asn-d6 · 2018-12-17T14:56:15Z

No description provided.

We need this for padding negotiation so that we can have later machine revisions supercede earlier ones.

This is a good code review start point, to get an overview of the interfaces and types used in circuit padding.

This helps us to determine if a middle node can pad to us or not.

These event callbacks allow circuit padding to decide when to attempt to launch and negotiate new padding machines, and when to tear old ones down.

These callbacks allow the padding state machines to react to various types of sent and received relay cells.

This implements all of the event handling, state machines, and padding decisions for circuit padding. I recommend reviewing this after you look at the call-in points into it from the rest of Tor.

Hope is this will make it easier to test on the live tor network. Does not need to be merged if we don't want to, but will come in handy for researchers.

Note to self/others: don't merge this.

This project introduces the prob_distr.c subsystem which implements all the probability distributions that WTF-PAD needs. It also adds unittests for all of them. Code and tests courtesy of Riastradh. Code torification by asn. Co-authored-by: Taylor R Campbell <campbell+tor@mumble.net>

Also add some basic tests for sampling delays from the uniform distribution.

coveralls · 2018-12-17T16:25:28Z

Pull Request Test Coverage Report for Build 3318

910 of 985 (92.39%) changed or added relevant lines in 14 files are covered.
14 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.5%) to 61.288%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/app/config/config.c	1	2	50.0%
src/core/or/versions.c	1	2	50.0%
src/feature/nodelist/routerlist.c	1	2	50.0%
src/core/or/circuituse.c	3	5	60.0%
src/core/or/connection_edge.c	0	2	0.0%
src/lib/math/prob_distr.c	206	208	99.04%
src/core/or/relay.c	5	11	45.45%
src/core/or/circuitbuild.c	2	13	15.38%
src/core/or/circuitpadding.c	681	730	93.29%

Files with Coverage Reduction	New Missed Lines	%
src/core/or/circuitbuild.c	2	42.12%
src/feature/dirauth/shared_random.c	3	85.64%
src/feature/dirauth/dirvote.c	9	64.94%

Totals
Change from base Build 3287:	0.5%
Covered Lines:	44480
Relevant Lines:	72575

💛 - Coveralls

mikeperry-tor and others added 17 commits Nov 30, 2018

Provide a smartlist reverse-order traversal.

3165c8c

We need this for padding negotiation so that we can have later machine revisions supercede earlier ones.

Circuit padding header.

ae8ed95

This is a good code review start point, to get an overview of the interfaces and types used in circuit padding.

Hook up circuit padding to circuit_t.

956f07a

Initialize circuit padding machines and global state.

b94c10c

Circuit padding ProtoVer plumbing.

7353886

This helps us to determine if a middle node can pad to us or not.

Add padding negotiation trunnel output.

2ccd9c0

Circuit padding machine creation events.

59823f3

These event callbacks allow circuit padding to decide when to attempt to launch and negotiate new padding machines, and when to tear old ones down.

Circuit padding cell event callbacks.

447bb9c

These callbacks allow the padding state machines to react to various types of sent and received relay cells.

Circuit padding implementation.

5bbd8b2

This implements all of the event handling, state machines, and padding decisions for circuit padding. I recommend reviewing this after you look at the call-in points into it from the rest of Tor.

Add relay crypto mock points for tests.

22c3686

Circuit padding tests.

117bb7c

Config option to specify specific MiddleNodes.

62bd7d0

Hope is this will make it easier to test on the live tor network. Does not need to be merged if we don't want to, but will come in handy for researchers.

Add TODO file for padding work.

29282fa

Note to self/others: don't merge this.

Use the new probability distribution code in WTF-PAD.

4c54a89

Also add some basic tests for sampling delays from the uniform distribution.

Concentrate all TOR_USEC_PER_SEC definitions in a single header file.

56d21d0

fixup! Circuit padding tests.

953b7c2

asn-d6 closed this Dec 27, 2018

torproject / tor Public

Adaptive padding rebased 0.3.6 pr547 squashed final rebase squashed #601

Adaptive padding rebased 0.3.6 pr547 squashed final rebase squashed #601

asn-d6 commented Dec 17, 2018

coveralls commented Dec 17, 2018 •

edited

torproject / tor Public

Adaptive padding rebased 0.3.6 pr547 squashed final rebase squashed #601

Adaptive padding rebased 0.3.6 pr547 squashed final rebase squashed #601

Conversation

asn-d6 commented Dec 17, 2018

coveralls commented Dec 17, 2018 • edited

Pull Request Test Coverage Report for Build 3318

💛 - Coveralls

coveralls commented Dec 17, 2018 •

edited