New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try @warning_flags to avoid bloating verbose make logs #614

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

nmathewson commented Dec 21, 2018

We now accumulate warning flags in a separate variable,
"TOR_WARNING_FLAGS", and write it to a "warning_flags" file. Then
we test whether the compiler will accept "@warning_flags": if so, we
put "@warning_flags" in the CFLAGS; if not, we copy the contents of
"$TOR_WARNING_FLAGS" into the CFLAGS.

Closes ticket 28924.

Try @warning_flags to avoid bloating verbose make logs
We now accumulate warning flags in a separate variable,
"TOR_WARNING_FLAGS", and write it to a "warning_flags" file.  Then
we test whether the compiler will accept "@warning_flags": if so, we
put "@warning_flags" in the CFLAGS; if not, we copy the contents of
"$TOR_WARNING_FLAGS" into the CFLAGS.

Closes ticket 28924.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 21, 2018

Pull Request Test Coverage Report for Build 3371

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.312%

Totals Coverage Status
Change from base Build 3353: 0.0%
Covered Lines: 42848
Relevant Lines: 71044

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 97c9ced into torproject:maint-0.3.5 Dec 21, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment