#20006: Allow for client auth when responding to HSFETCH #621
Conversation
Until now Tor could not respond to HSFETCH command properly if target Onion Service had client auth enabled. Now it checks if we have an entry for requested address in our map of configured auth cookies. If one is found, auth cookie is used to request HSDesc.
Pull Request Test Coverage Report for Build 3692
|
dgoulet-tor
reviewed
Jan 21, 2019
src/feature/control/control.c
Outdated
| rend_auth_type_t auth_type = REND_NO_AUTH; | ||
| rend_service_authorization_t *auth = NULL; | ||
|
|
||
| char *cookie = NULL; |
This should be const.
Fixed in b93f414.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Until now Tor could not respond to HSFETCH command properly if
target Onion Service had client auth enabled. Now it checks if
we have an entry for requested address in our map of configured auth
cookies. If one is found, auth cookie is used to request HSDesc.
https://trac.torproject.org/projects/tor/ticket/20006
The text was updated successfully, but these errors were encountered: