Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29060: Fix shellcheck warnings in #680

merged 6 commits into from Mar 5, 2019


None yet
3 participants
Copy link

commented Feb 2, 2019

rl1987 added some commits Feb 2, 2019

Update to bash script to use array
This lets us to save original script argument to array (POSIX shell does not
support that). Fixes shellcheck warnings SC2124 and SC2086.

This comment has been minimized.

Copy link

commented Feb 2, 2019

Pull Request Test Coverage Report for Build 3925

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2444 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.01%) to 61.75%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_service.c 1 73.78%
src/feature/hs/hs_client.c 2 51.32%
src/core/mainloop/connection.h 3 50.0%
src/core/crypto/relay_crypto.c 5 85.0%
src/lib/tls/x509_openssl.c 7 95.21%
src/core/proto/proto_socks.c 11 92.72%
src/core/or/circuitpadding.c 18 95.08%
src/feature/dirauth/bwauth.c 18 89.19%
src/lib/crypt_ops/crypto_rsa.c 18 92.49%
src/core/or/circuitlist.c 23 57.68%
Totals Coverage Status
Change from base Build 3704: -0.01%
Covered Lines: 45331
Relevant Lines: 73411

💛 - Coveralls

rl1987 added some commits Feb 13, 2019

Walk back from requiring bash
Refrain from using bash array to remember $@.

@torproject-pusher torproject-pusher merged commit c346eff into torproject:master Mar 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.