Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug13221 maint-0.2.9 #726

Open
wants to merge 1 commit into
base: maint-0.2.9
from

Conversation

Projects
None yet
2 participants
@katterjohn
Copy link
Contributor

katterjohn commented Feb 25, 2019

Trac ticket: https://trac.torproject.org/projects/tor/ticket/13221
Original PR for master merge: #669

This is a rebase of the commits in the PR above for maint-0.2.9.

Fix some error-checking logic and a misleading error message
When IPv4Only (IPv6Only) was used but the address could not be
interpreted as a IPv4 (IPv6) address, the error message referred
to the wrong IP version.

This also fixes up the error-checking logic so it's more precise
about what's being checked.

Fixes bug 13221; bugfix on 0.2.3.9-alpha

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 25, 2019

Pull Request Test Coverage Report for Build 3943

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 50.018%

Files with Coverage Reduction New Missed Lines %
src/ext/trunnel/trunnel.c 1 34.48%
src/or/circuitstats.c 2 73.71%
Totals Coverage Status
Change from base Build 3781: 0.0%
Covered Lines: 29422
Relevant Lines: 58823

💛 - Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.