Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket29530 035: backport Some address/get_if_addrs* tests fail when the network is unreachable #727

Merged
merged 2 commits into from Mar 19, 2019
Merged

Ticket29530 035: backport Some address/get_if_addrs* tests fail when the network is unreachable #727

merged 2 commits into from Mar 19, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @nmathewson
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 26, 2019

No description provided.

nmathewson and others added 2 commits Feb 25, 2019
@nmathewson @teor2345
Downgrade some LOG_ERR messages in the address/* tests to warnings
e138bb8 
Fixes bug 29530, where the LOG_ERR messages were occurring when
we had no configured network, and so we were failing the unit tests
because of the recently-merged #28668.

Commit message edited by teor:

We backported 28668 and released it in 0.3.5.8.
This commit backports 29530 to 0.3.5.

Fixes bug 29530 in Tor 0.3.5.8.
@teor2345
Changes file for backporting 29530 to 0.3.5
cc23afd
@coveralls
Copy link

@coveralls coveralls commented Feb 26, 2019

Pull Request Test Coverage Report for Build 3944

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 60.317%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 83.28%
Totals Coverage Status
Change from base Build 3919: 0.02%
Covered Lines: 42865
Relevant Lines: 71066
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit cc23afd into torproject:maint-0.3.5 Mar 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment