Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tor Trac #17357]: rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ() #739

Merged
merged 1 commit into from Mar 4, 2019
Merged

[Tor Trac #17357]: rend_service_relaunch_rendezvous() ignores hs_service_requires_uptime_circ() #739

merged 1 commit into from Mar 4, 2019

Conversation

Reviewers

@dgoulet-tor dgoulet-tor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@neelchauhan @coveralls @dgoulet-tor @torproject-pusher
@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented Feb 27, 2019

For the ticket here.
dgoulet-tor
dgoulet-tor reviewed Feb 27, 2019
View changes
src/feature/rend/rendservice.c Outdated
rend_pk_digest = (char *) rend_data_get_pk_digest(oldcirc->rend_data, NULL);

base32_encode(serviceid, REND_SERVICE_ID_LEN_BASE32+1,
rend_pk_digest, REND_SERVICE_ID_LEN);
Copy link
Contributor

@dgoulet-tor dgoulet-tor Feb 27, 2019

If we can move this in the if() below because we only do that for logging.

src/feature/rend/rendservice.c Outdated
service = rend_service_get_by_pk_digest(rend_pk_digest);
if (!service) {
log_warn(LD_BUG, "Internal error: Trying to relaunch a rendezvous circ "
"for an unrecognized service %s.", escaped(serviceid));
Copy link
Contributor

@dgoulet-tor dgoulet-tor Feb 27, 2019

At warning level here, we should safe_str_client() the serviceid.

@neelchauhan
Set CIRCLAUNCH_NEED_UPTIME in rend_service_relaunch_rendezvous() on a…
c142e3d 
… hs_service_requires_uptime_circ()
@coveralls
Copy link

@coveralls coveralls commented Feb 28, 2019 •
edited

Pull Request Test Coverage Report for Build 4002

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 61.699%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/rend/rendservice.c 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.45%
src/core/or/circuitpadding.c 10 93.71%
Totals Coverage Status
Change from base Build 3991: -0.02%
Covered Lines: 45328
Relevant Lines: 73466
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit c142e3d into torproject:master Mar 4, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment