Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

29144 035: Log the correct "auto" port number for listening sockets #745

Merged
merged 1 commit into from Apr 19, 2019
Merged

29144 035: Log the correct "auto" port number for listening sockets #745

merged 1 commit into from Apr 19, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@teor2345 @coveralls @torproject-pusher @rettakjak
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 1, 2019

When "auto" was used for the port number for a listening socket, the
message logged after opening the socket would incorrectly say port 0
instead of the actual port used.

Fixes bug 29144; bugfix on 0.3.5.1-alpha

Signed-off-by: Kris Katterjohn katterjohn@gmail.com
@rettakjak @teor2345
Log the correct "auto" port number for listening sockets
389ee83 
When "auto" was used for the port number for a listening socket, the
message logged after opening the socket would incorrectly say port 0
instead of the actual port used.

Fixes bug 29144; bugfix on 0.3.5.1-alpha

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
@teor2345 teor2345 changed the title Log the correct "auto" port number for listening sockets 29144 035: Log the correct "auto" port number for listening sockets Mar 1, 2019
@teor2345 teor2345 mentioned this pull request Mar 1, 2019
Closed
@teor2345 teor2345 mentioned this pull request Mar 1, 2019
Closed
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Mar 1, 2019

Closing and re-opening, because GitHub's API doesn't work well with multiple merge heads.

@teor2345 teor2345 closed this Mar 1, 2019
@teor2345 teor2345 reopened this Mar 1, 2019
@coveralls
Copy link

@coveralls coveralls commented Mar 1, 2019

Pull Request Test Coverage Report for Build 4036

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 60.317%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 83.28%
Totals Coverage Status
Change from base Build 4015: -0.001%
Covered Lines: 42865
Relevant Lines: 71066
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit 389ee83 into torproject:maint-0.3.5 Apr 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment