Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#29662: Introduce tor_assertf{_nonfatal}() to allow logging extra error message on assert failure #760

Closed
wants to merge 10 commits into from
Closed

#29662: Introduce tor_assertf{_nonfatal}() to allow logging extra error message on assert failure #760

wants to merge 10 commits into from

Conversation

Reviewers

@teor2345 teor2345

@ProrokEskobar ProrokEskobar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rl1987 @coveralls @teor2345 @ProrokEskobar
@rl1987
Copy link
Contributor

@rl1987 rl1987 commented Mar 5, 2019

https://trac.torproject.org/projects/tor/ticket/29662
rl1987 added 5 commits Mar 5, 2019
@rl1987
Introduce tor_assertf() to allow logging extra error message on asser…
f236c9e 
…t failure

With format string support!
@rl1987
Also add tor_assertf_nonfatal()
b681384
@rl1987
Silence compiler warnings
d134ce4
@rl1987
Use tor_assertf{_nonfatal} in code
3baeba9
@rl1987
Add changes file
8ef3c0d
@coveralls
Copy link

@coveralls coveralls commented Mar 6, 2019

Pull Request Test Coverage Report for Build 4080

  • 1 of 14 (7.14%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.0005%) to 61.704%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/log/util_bug.c 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/relay.c 1 49.33%
src/feature/hs/hs_common.c 1 83.28%
src/lib/log/util_bug.c 4 55.56%
Totals Coverage Status
Change from base Build 4068: 0.0005%
Covered Lines: 45341
Relevant Lines: 73481
💛 - Coveralls

teor2345
teor2345 reviewed Mar 22, 2019
View changes
src/lib/log/util_bug.c Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Mar 22, 2019
View changes
changes/ticket29662 Outdated Show resolved Hide resolved
teor2345
teor2345 reviewed Mar 22, 2019
View changes
src/lib/log/util_bug.c Outdated Show resolved Hide resolved
rl1987 added 5 commits Mar 22, 2019
@rl1987
Refrain from using static buffer for assert failure message; call tor…
b53a0bc 
…_asprintf() instead
@rl1987
squash! Use tor_assertf{_nonfatal} in code
2188aff
@rl1987
fixup! Add changes file
34c6eb2
@rl1987
fixup! Silence compiler warnings
999137d
@rl1987
fixup! Also add tor_assertf_nonfatal()
53192a6
@rl1987 rl1987 closed this Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment