Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocommas 034 #769

Open
wants to merge 5 commits into
base: maint-0.3.4
Choose a base branch
from
Open

Protocommas 034 #769

wants to merge 5 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @coveralls
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 8, 2019

No description provided.

cypherpunks and others added 5 commits Sep 15, 2018
rust/protover: reject extra commas
1ed5e00 
The C implementation had gotten this wrong too, in a slightly different way.

Introduced in 5af03c1.

Fixes #27197; bugfix on 0.3.3.3-alpha.
rust/protover: remove redundant ExceedsMax checks
b91bc1b 
This is already checked elsewhere.
@teor2345
protover: reject unexpected commas
adb3ef7 
Consistently reject extra commas, instead of only rejecting leading
commas.

Fix on b2b2e1c.
Fixes #27194; bugfix on 0.2.9.4-alpha.
@teor2345
Merge branch 'protocommas_029_squashed' into protocommas_034
cd207c5
@teor2345
Merge remote-tracking branch 'gh/rust-protocommas1' into protocommas_034
504ca1e
@coveralls
Copy link

@coveralls coveralls commented Mar 8, 2019

Pull Request Test Coverage Report for Build 4132

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 59.875%
Totals Coverage Status
Change from base Build 4101: 0.02%
Covered Lines: 41798
Relevant Lines: 69809
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment