Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/sr: Free SRVs before replacing them in test_sr_setup_srv() #774

Merged
merged 2 commits into from Mar 19, 2019
Merged

test/sr: Free SRVs before replacing them in test_sr_setup_srv() #774

merged 2 commits into from Mar 19, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 9, 2019

Stop leaking parts of the shared random state in the shared-random unit
tests. The previous fix in 29599 was incomplete.

Fixes bug 29706; bugfix on 0.2.9.1-alpha.
@teor2345
test/sr: Free SRVs before replacing them in test_sr_setup_srv()
9400da9 
Stop leaking parts of the shared random state in the shared-random unit
tests. The previous fix in 29599 was incomplete.

Fixes bug 29706; bugfix on 0.2.9.1-alpha.
@coveralls
Copy link

@coveralls coveralls commented Mar 9, 2019 •
edited

Pull Request Test Coverage Report for Build 4258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1464 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.1%) to 50.152%
Files with Coverage Reduction New Missed Lines %
src/or/dirserv.c 1 35.87%
src/or/or.h 1 75.0%
src/common/compat.c 29 66.22%
src/or/circuitstats.c 70 74.72%
src/or/relay.c 201 24.29%
src/or/circuitlist.c 270 52.27%
src/or/circuituse.c 399 1.11%
src/or/rephist.c 493 31.36%
Totals Coverage Status
Change from base Build 4103: 0.1%
Covered Lines: 29514
Relevant Lines: 58849
💛 - Coveralls

@teor2345
test/sr: Clear SRVs after init, and before setup
c44ad39 
Already merged to 0.4.0 and later in tor-github/pr/776.
Backported to 0.2.9 and later with minor comment changes.

Part of 29706.
@torproject-pusher torproject-pusher merged commit c44ad39 into torproject:maint-0.2.9 Mar 19, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment