Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shellcheck warnings in pull-all/merge-all scripts #783

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Labels
None yet
Projects
None yet
3 participants
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Mar 12, 2019

This appears at first glance to be a shellcheck bug.

Closes 29747. Bugfix not in any released Tor.

This appears at first glance to be a shellcheck bug.

Closes 29747.  Bugfix not in any released Tor.
@coveralls
Copy link

@coveralls coveralls commented Mar 12, 2019

Pull Request Test Coverage Report for Build 4171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1196 unchanged lines in 36 files lost coverage.
  • Overall coverage decreased (-1.6%) to 61.719%

Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_service.c 1 73.85%
src/feature/dirclient/dirclient.c 1 18.37%
src/feature/nodelist/nodelist.c 2 71.88%
src/core/or/policies.c 2 84.52%
src/feature/nodelist/microdesc.c 2 72.75%
src/lib/buf/buffers.c 2 90.93%
src/feature/client/addressmap.c 2 60.54%
src/feature/rend/rendcache.c 2 93.02%
src/lib/evloop/token_bucket.h 2 66.67%
src/lib/fs/files.c 2 67.21%
Totals Coverage Status
Change from base Build 4154: -1.6%
Covered Lines: 45346
Relevant Lines: 73472

💛 - Coveralls

@torproject-pusher torproject-pusher merged commit a6dd893 into torproject:master Mar 13, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment