Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug29706 034 minimal merge #801

Merged
merged 4 commits into from Mar 19, 2019
Merged

Bug29706 034 minimal merge #801

merged 4 commits into from Mar 19, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@teor2345 @coveralls @torproject-pusher
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 18, 2019

No description provided.

teor2345 added 4 commits Mar 9, 2019
@teor2345
test/sr: Free SRVs before replacing them in test_sr_setup_srv()
9400da9 
Stop leaking parts of the shared random state in the shared-random unit
tests. The previous fix in 29599 was incomplete.

Fixes bug 29706; bugfix on 0.2.9.1-alpha.
@teor2345
test/sr: Clear SRVs after init, and before setup
c44ad39 
Already merged to 0.4.0 and later in tor-github/pr/776.
Backported to 0.2.9 and later with minor comment changes.

Part of 29706.
@teor2345
Merge branch 'bug29706_029_minimal' into bug29706_034_minimal_merge
1d0146e
@teor2345
test/sr: update sr_state_free() to sr_state_free_all() in a comment
aec6ee2
@coveralls
Copy link

@coveralls coveralls commented Mar 18, 2019

Pull Request Test Coverage Report for Build 4259

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 59.94%
Files with Coverage Reduction New Missed Lines %
src/or/dirauth/shared_random.c 1 86.39%
src/or/dirauth/dirvote.c 1 65.53%
src/or/routerparse.c 6 76.57%
Totals Coverage Status
Change from base Build 4216: -0.01%
Covered Lines: 41855
Relevant Lines: 69828
💛 - Coveralls

@torproject-pusher torproject-pusher merged commit aec6ee2 into torproject:maint-0.3.4 Mar 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment