Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make reset-gcov after the script target in Travis CI is done. #806

Merged
2 commits merged into from Apr 5, 2019

Conversation

ahf
Copy link
Member

@ahf ahf commented Mar 19, 2019

@coveralls
Copy link

coveralls commented Mar 19, 2019

Pull Request Test Coverage Report for Build 4310

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 50.127%

Files with Coverage Reduction New Missed Lines %
src/or/dirvote.c 1 68.55%
src/or/shared_random.c 4 85.38%
src/or/routerparse.c 15 72.77%
Totals Coverage Status
Change from base Build 4288: -0.03%
Covered Lines: 29499
Relevant Lines: 58849

💛 - Coveralls

This should ensure that GCDA files are never entering the cache of
Travis CI.

See: https://bugs.torproject.org/29036
Since we have moved coveralls to the script target the entire build will
now fail if coveralls fail. We handle it more gracefully by echo'ing the
failure instead of doing a hard-failure.

See: https://bugs.torproject.org/29036
@ghost ghost merged commit fbb1c7a into torproject:maint-0.2.9 Apr 5, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants