Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run make reset-gcov after the script target in Travis CI is done. #806

Merged
merged 2 commits into from Apr 5, 2019
Merged

Run make reset-gcov after the script target in Travis CI is done. #806

merged 2 commits into from Apr 5, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ahf @coveralls @torproject-pusher
@ahf
Copy link
Member

@ahf ahf commented Mar 19, 2019

See: https://bugs.torproject.org/29036
@ahf ahf force-pushed the ahf/bugs29036-029 branch from 3607e86 to deb48d9 Mar 19, 2019
@coveralls
Copy link

@coveralls coveralls commented Mar 19, 2019 •
edited

Pull Request Test Coverage Report for Build 4310

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 50.127%
Files with Coverage Reduction New Missed Lines %
src/or/dirvote.c 1 68.55%
src/or/shared_random.c 4 85.38%
src/or/routerparse.c 15 72.77%
Totals Coverage Status
Change from base Build 4288: -0.03%
Covered Lines: 29499
Relevant Lines: 58849
💛 - Coveralls

@ahf
Run `make reset-gcov` after the script target in Travis CI is done.
0267c45 
This should ensure that GCDA files are never entering the cache of
Travis CI.

See: https://bugs.torproject.org/29036
@ahf ahf force-pushed the ahf/bugs29036-029 branch from deb48d9 to 0267c45 Mar 20, 2019
@ahf
Handle errors from coveralls more gracefully.
fbb1c7a 
Since we have moved coveralls to the script target the entire build will
now fail if coveralls fail. We handle it more gracefully by echo'ing the
failure instead of doing a hard-failure.

See: https://bugs.torproject.org/29036
@ahf ahf force-pushed the ahf/bugs29036-029 branch from d411592 to fbb1c7a Mar 20, 2019
@torproject-pusher torproject-pusher merged commit fbb1c7a into torproject:maint-0.2.9 Apr 5, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment